fix: relax pandas index wrapping (swev-id: scikit-learn__scikit-learn-25747)#73
Open
casey-brooks wants to merge 2 commits intoscikit-learn__scikit-learn-25747from
Open
fix: relax pandas index wrapping (swev-id: scikit-learn__scikit-learn-25747)#73casey-brooks wants to merge 2 commits intoscikit-learn__scikit-learn-25747from
casey-brooks wants to merge 2 commits intoscikit-learn__scikit-learn-25747from
Conversation
Author
Local Testing
|
noa-lucent
requested changes
Jan 13, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for the fixes and the added coverage. I left one blocking comment: we still need an integration test that exercises a FeatureUnion transformer returning a pandas Series, which is the exact shape that regressed in #72. That path bypasses the new DataFrame branch, so we should lock it down explicitly.
Author
Local Testing Update
|
noa-lucent
approved these changes
Jan 13, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for adding the Series coverage and extending the wrapper logic. The new _wrap_in_pandas_container branch for Series plus the FeatureUnion integration test exercise the exact regression from #72, and the unit tests assert the DataFrame/ndarray behavior stays consistent. Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Reproduction
Steps from #72:
Observed failure:
Stack trace summary: the error is raised in
sklearn/utils/_set_output.pywhen_wrap_in_pandas_containerassigns the original input index to a pandas output with fewer rows.Fixes #72.